Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfitsio: update to 4.5.0 #22036

Merged
merged 2 commits into from
Sep 26, 2024
Merged

cfitsio: update to 4.5.0 #22036

merged 2 commits into from
Sep 26, 2024

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Sep 25, 2024 •
edited
Loading

Will need all deps rebuilt because of soname change:

mingw-w64-ucrt-x86_64-gdal
mingw-w64-ucrt-x86_64-gimp3
mingw-w64-ucrt-x86_64-libvips
mingw-w64-ucrt-x86_64-python-imagecodecs

@kmilos kmilos marked this pull request as draft September 25, 2024 12:26
@kmilos
Copy link
Contributor Author

kmilos commented Sep 25, 2024

Hm, also need to remove the redundant "lib/"...

@ognevny
Copy link
Collaborator

ognevny commented Sep 25, 2024

Hm, also need to remove the redundant "lib/"...

-DCMAKE_INSTALL_LIBDIR can't be set?

@kmilos
Copy link
Contributor Author

kmilos commented Sep 25, 2024 •
edited
Loading

-DCMAKE_INSTALL_LIBDIR can't be set?

No, it affects only the cmake and pkgconf files, not the actual libs...

It's an upstream regression.

Edit: looks like Arch patched this already, using the same here...

@kmilos kmilos marked this pull request as ready for review September 25, 2024 13:00
kmilos and others added 2 commits September 26, 2024 09:26
@kmilos @lazka
cfitsio: update to 4.5.0
4257555 
* fix install dir for pc and cmake files
* fix phtreads dependency
* remove unused curl dep
@lazka
cfitsio rebuilds
b08bf4a
@lazka lazka merged commit ecf6328 into msys2:master Sep 26, 2024
5 checks passed
@lazka
Copy link
Member

lazka commented Sep 26, 2024 •
edited
Loading

python-imagecodecs seems to have vendored parts of cfitsio and is no longer using it directly, so not rebuilding that

@kmilos
Copy link
Contributor Author

kmilos commented Sep 26, 2024 •
edited
Loading

Thanks!

python-imagecodecs seems to have vendored parts of cfitsio and is no longer using it directly, so not rebuilding that

Rings a bell, there was an issue w/ cfitsio not exporting the symbols imagecodecs was using on Windows so parts of it had to be linked in statically, don't know if that changed since...

Edit: no change, imagecodecs takes (and modifies) just the cfitsio source it needs and now vendors it for all platforms, so this dep can be removed actually.

@kmilos kmilos deleted the patch-2 branch September 26, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmilos @ognevny @lazka